X-Git-Url: http://shamusworld.gotdns.org/cgi-bin/gitweb.cgi?p=rmac;a=blobdiff_plain;f=mark.c;h=955fcab0c7a81d0535c4e06b625be8dab1fae07a;hp=088263b2c0271d795f33b043046fda331f01bd97;hb=ada93ab0c3763d4a4ab607cbc73c24d74bc94ff4;hpb=03dd34951a331e0b8971195ccef1600fffaea2e6

diff --git a/mark.c b/mark.c
index 088263b..955fcab 100644
--- a/mark.c
+++ b/mark.c
@@ -90,18 +90,13 @@ if (symbol)
 
 	//
 	// Complain about some things are not allowed in '-p' (PRG) mode:
-	//  o Marks that aren't to LONGs
-	//  o External references
+	//  o  Marks that aren't to LONGs
+	//  o  External references
 	//
 	if (prg_flag)
 	{
-#if 0
-		if ((flags & MLONG) == 0)
-			error("illegal word relocatable (in .PRG mode)");
-#endif
-
 		if (symbol != NULL)
-			errors("illegal external reference (in .PRG mode) to '%s'",
+			error("illegal external reference (in .PRG mode) to '%s'",
 				symbol->sname);
 	}
 
@@ -382,6 +377,12 @@ printf(" validsegment: raddr = $%08X\n", loc);
 			if (w & MMOVEI)
 				rflag |= 0x00000001;
 
+			// This tells the linker to do a WORD relocation (otherwise it
+			// defaults to doing a LONG, throwing things off for WORD sized
+			// fixups)
+			if (!(w & MLONG))
+				rflag |= 0x00000002;
+
 			if (symbol != NULL)
 			{
 				// Deposit external reference
@@ -419,7 +420,7 @@ printf("  validsegment(3): rflag = $%08X\n", rflag);
 					if (from == DATA)
 						dp += tsize;
 
-					uint32_t diff = GETBE32(dp, 0);
+					uint32_t diff = (rflag & 0x02 ? GETBE16(dp, 0) : GETBE32(dp, 0));
 					DEBUG printf("diff=%uX ==> ", diff);
 #ifdef DEBUG_IMAGE_MARKING
 printf("  validsegment(4): diff = $%08X --> ", diff);
@@ -435,7 +436,21 @@ printf("  validsegment(4): diff = $%08X --> ", diff);
 					if (rflag & 0x01)
 						diff = WORDSWAP32(diff);
 
-					SETBE32(dp, 0, diff);
+					// Make sure to deposit the correct size payload
+					// N.B.: The braces around the SETBExx macros are needed
+					//       because the macro supplies its own set of braces,
+					//       thus leaving a naked semicolon afterwards to
+					//       screw up the if/else structure. This is the price
+					//       you pay when using macros pretending to be code.
+					if (rflag & 0x02)
+					{
+						SETBE16(dp, 0, diff);
+					}
+					else
+					{
+						SETBE32(dp, 0, diff);
+					}
+
 					DEBUG printf("%uX\n", diff);
 #ifdef DEBUG_IMAGE_MARKING
 printf("$%08X\n", diff);
@@ -533,7 +548,7 @@ uint32_t CreateELFRelocationRecord(uint8_t * buf, uint8_t * secBuf, uint16_t sec
 
 				// Deposit the relocation record
 				D_long(r_offset);
-				D_long((r_sym << 8) | r_type);
+				D_long(((r_sym << 8) | r_type));
 				D_long(r_addend);
 				rsize += 0x0C;
 			}