X-Git-Url: http://shamusworld.gotdns.org/cgi-bin/gitweb.cgi?p=rmac;a=blobdiff_plain;f=expr.c;h=270c072c621c2618728a736d8fe3b7bd54798bff;hp=b86111bd579769168ecad264fb1d087f57b02ba8;hb=4205233c8397c581b4d27ab36ab81ec896ef3dd0;hpb=29b32d134bc12831a8ddd098bf9aeeda26dcfe7c

diff --git a/expr.c b/expr.c
index b86111b..270c072 100644
--- a/expr.c
+++ b/expr.c
@@ -1,7 +1,7 @@
-
+//
 // RMAC - Reboot's Macro Assembler for all Atari computers
 // EXPR.C - Expression Analyzer
-// Copyright (C) 199x Landon Dyer, 2011-2017 Reboot and Friends
+// Copyright (C) 199x Landon Dyer, 2011-2020 Reboot and Friends
 // RMAC derived from MADMAC v1.07 Written by Landon Dyer, 1986
 // Source utilised with the kind permission of Landon Dyer
 //
@@ -36,7 +36,7 @@ char itokcl[] = {
 	CR_STREQ, CR_MACDEF,
 	CR_DATE, CR_TIME,
 	CR_ABSCOUNT, 0,
-	'!', '~', UNMINUS, 0,			// UNARY
+	'!', '~', UNMINUS, UNLT, UNGT, 0,	// UNARY
 	'*', '/', '%', 0,				// MULT
 	'+', '-', 0,					// ADD
 	SHL, SHR, 0,					// SHIFT
@@ -49,6 +49,7 @@ char itokcl[] = {
 
 const char missym_error[] = "missing symbol";
 const char str_error[] = "missing symbol or string";
+const char noflt_error[] = "operator not usable with float";
 
 // Convert expression to postfix
 static PTR evalTokenBuffer;		// Deposit tokens here (this is really a
@@ -125,23 +126,24 @@ int expr0(void)
 //
 int expr1(void)
 {
-	TOKEN t;
-	SYM * sy;
-	char * p, * p2;
+	char * p;
 	WORD w;
-	int j;
 
 	int class = tokenClass[*tok];
 
-	if (*tok == '-' || *tok == '+' || class == UNARY)
+	if (*tok == '-' || *tok == '+' || *tok == '<' || *tok == '>' || class == UNARY)
 	{
-		t = *tok++;
+		TOKEN t = *tok++;
 
 		if (expr2() != OK)
 			return ERROR;
 
 		if (t == '-')
 			t = UNMINUS;
+		else if (t == '<')
+			t = UNLT;
+		else if (t == '>')
+			t = UNGT;
 
 		// With leading + we don't have to deposit anything to the buffer
 		// because there's no unary '+' nor we have to do anything about it
@@ -153,8 +155,16 @@ int expr1(void)
 		switch (*tok++)
 		{
 		case CR_ABSCOUNT:
-			*evalTokenBuffer.u32++ = CONST;
-			*evalTokenBuffer.u64++ = (uint64_t)sect[ABS].sloc;
+			if (cursect != ABS)
+			{
+				*evalTokenBuffer.u32++ = CONST;
+				*evalTokenBuffer.u64++ = sect[ABS].sloc;
+			}
+			else
+			{
+				*evalTokenBuffer.u32++ = CONST;
+				*evalTokenBuffer.u64++ = sloc;
+			}
 			break;
 		case CR_TIME:
 			*evalTokenBuffer.u32++ = CONST;
@@ -183,8 +193,9 @@ getsym:
 				return error(missym_error);
 
 			p = string[*tok++];
-			j = (*p == '.' ? curenv : 0);
-			w = ((sy = lookup(p, LABEL, j)) != NULL && (sy->sattr & w) ? 1 : 0);
+			int j = (*p == '.' ? curenv : 0);
+			SYM * sy = lookup(p, LABEL, j);
+			w = ((sy != NULL) && (sy->sattr & w ? 1 : 0));
 			*evalTokenBuffer.u32++ = CONST;
 			*evalTokenBuffer.u64++ = (uint64_t)w;
 			break;
@@ -201,7 +212,7 @@ getsym:
 			if (*tok != SYMBOL && *tok != STRING)
 				return error(str_error);
 
-			p2 = string[tok[1]];
+			char * p2 = string[tok[1]];
 			tok += 2;
 
 			w = (WORD)(!strcmp(p, p2));
@@ -222,9 +233,6 @@ getsym:
 //
 int expr2(void)
 {
-	char * p;
-	SYM * sy;
-	int j;
 	PTR ptk;
 
 	switch (*tok++)
@@ -242,9 +250,10 @@ int expr2(void)
 		tok = ptk.u32;
 		break;
 	case SYMBOL:
-		p = string[*tok++];
-		j = (*p == '.' ? curenv : 0);
-		sy = lookup(p, LABEL, j);
+	{
+		char * p = string[*tok++];
+		int j = (*p == '.' ? curenv : 0);
+		SYM * sy = lookup(p, LABEL, j);
 
 		if (sy == NULL)
 			sy = NewSymbol(p, LABEL, j);
@@ -264,6 +273,7 @@ int expr2(void)
 		symbolPtr[symbolNum] = sy;
 		symbolNum++;
 		break;
+ 	}
 	case STRING:
 		*evalTokenBuffer.u32++ = CONST;
 		*evalTokenBuffer.u64++ = str_value(string[*tok++]);
@@ -494,10 +504,15 @@ thrown away right here. What the hell is it for?
 
 			tok += 2;
 		}
+		// Holy hell... This is likely due to the fact that LSR is mistakenly set as a SUNARY type... Need to fix this... !!! FIX !!!
+		else if (m6502)
+		{
+			*evalTokenBuffer.u32++ = *tok++;
+		}
 		else
 		{
 			// Unknown type here... Alert the user!,
-			error("undefined RISC register in expression");
+			error("undefined RISC register in expression [token=$%X]", *tok);
 			// Prevent spurious error reporting...
 			tok++;
 			return ERROR;
@@ -523,7 +538,7 @@ thrown away right here. What the hell is it for?
 //
 int evexpr(TOKEN * _tk, uint64_t * a_value, WORD * a_attr, SYM ** a_esym)
 {
-	WORD attr, attr2;
+	WORD attr;
 	SYM * sy;
 	uint64_t * sval = evstk;				// (Empty) initial stack
 	WORD * sattr = evattr;
@@ -691,6 +706,30 @@ printf("EVEXPR (-): sym1 = %X, sym2 = %X\n", attr, sattr[1]);
 
 			break;
 
+		case UNLT: // Unary < (get the low byte of a word)
+//printf("evexpr(): UNLT\n");
+			if (*sattr & TDB)
+				return error(seg_error);
+
+			if (*sattr & FLOAT)
+				return error(noflt_error);
+
+			*sval = (int64_t)((*sval) & 0x00FF);
+			*sattr = ABS | DEFINED;			// Expr becomes absolute
+			break;
+
+		case UNGT: // Unary > (get the high byte of a word)
+//printf("evexpr(): UNGT\n");
+			if (*sattr & TDB)
+				return error(seg_error);
+
+			if (*sattr & FLOAT)
+				return error(noflt_error);
+
+			*sval = (int64_t)(((*sval) >> 8) & 0x00FF);
+			*sattr = ABS | DEFINED;			// Expr becomes absolute
+			break;
+
 		case '!':
 //printf("evexpr(): !\n");
 			if (*sattr & TDB)
@@ -900,11 +939,10 @@ printf("EVEXPR (-): sym1 = %X, sym2 = %X\n", attr, sattr[1]);
 
 		// All other binary operators must have two ABS items to work with.
 		// They all produce an ABS value.
+		// Shamus: Is this true? There's at least one counterexample of legit
+		//         code where this assumption fails to produce correct code.
 		default:
 //printf("evexpr(): default\n");
-			// GH - Removed for v1.0.15 as part of the fix for indexed loads.
-			//if ((*sattr & (TEXT|DATA|BSS)) || (*--sattr & (TEXT|DATA|BSS)))
-			//error(seg_error);
 
 			switch ((int)tk.u32[-1])
 			{
@@ -936,7 +974,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 				}
 //printf("%i\n", *sval);
 
-				*sattr = ABS | DEFINED | attr;		// Expr becomes absolute
+//no				*sattr = ABS | DEFINED | attr;		// Expr becomes absolute
 				break;
 
 			case '/':
@@ -974,7 +1012,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 				}
 //printf("%i\n", *sval);
 
-				*sattr = ABS | DEFINED | attr;		// Expr becomes absolute
+//no				*sattr = ABS | DEFINED | attr;		// Expr becomes absolute
 				break;
 
 			case '%':
@@ -988,7 +1026,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 					return error("mod (%) by zero");
 
 				*sval %= sval[1];
-				*sattr = ABS | DEFINED;			// Expr becomes absolute
+//no				*sattr = ABS | DEFINED;			// Expr becomes absolute
 				break;
 
 			case SHL:
@@ -999,7 +1037,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 					return error("floating point numbers not allowed with operator '<<'.");
 
 				*sval <<= sval[1];
-				*sattr = ABS | DEFINED;			// Expr becomes absolute
+//no				*sattr = ABS | DEFINED;			// Expr becomes absolute
 				break;
 
 			case SHR:
@@ -1010,7 +1048,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 					return error("floating point numbers not allowed with operator '>>'.");
 
 				*sval >>= sval[1];
-				*sattr = ABS | DEFINED;			// Expr becomes absolute
+//no				*sattr = ABS | DEFINED;			// Expr becomes absolute
 				break;
 
 			case '&':
@@ -1021,7 +1059,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 					return error("floating point numbers not allowed with operator '&'.");
 
 				*sval &= sval[1];
-				*sattr = ABS | DEFINED;			// Expr becomes absolute
+//no				*sattr = ABS | DEFINED;			// Expr becomes absolute
 				break;
 
 			case '^':
@@ -1032,7 +1070,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 					return error("floating point numbers not allowed with operator '^'.");
 
 				*sval ^= sval[1];
-				*sattr = ABS | DEFINED;			// Expr becomes absolute
+//no				*sattr = ABS | DEFINED;			// Expr becomes absolute
 				break;
 
 			case '|':
@@ -1043,7 +1081,7 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 					return error("floating point numbers not allowed with operator '|'.");
 
 				*sval |= sval[1];
-				*sattr = ABS | DEFINED;			// Expr becomes absolute
+//no				*sattr = ABS | DEFINED;			// Expr becomes absolute
 				break;
 
 			default:
@@ -1066,3 +1104,27 @@ An open question here is do we promote ints to floats as signed or unsigned? It
 	return OK;
 }
 
+
+//
+// Count the # of tokens in the passed in expression
+// N.B.: 64-bit constants count as two tokens each
+//
+uint16_t ExpressionLength(TOKEN * tk)
+{
+	uint16_t length;
+
+	for(length=0; tk[length]!=ENDEXPR; length++)
+	{
+		// Add one to length for 2X tokens, two for 3X tokens
+		if (tk[length] == SYMBOL)
+			length++;
+		else if ((tk[length] == CONST) || (tk[length] == FCONST))
+			length += 2;
+	}
+
+	// Add 1 for ENDEXPR
+	length++;
+
+	return length;
+}
+