//
-// RMAC - Reboot's Macro Assembler for the Atari Jaguar Console System
+// RMAC - Reboot's Macro Assembler for all Atari computers
// RISCA.C - GPU/DSP Assembler
-// Copyright (C) 199x Landon Dyer, 2011 Reboot and Friends
+// Copyright (C) 199x Landon Dyer, 2011-2018 Reboot and Friends
// RMAC derived from MADMAC v1.07 Written by Landon Dyer, 1986
-// Source Utilised with the Kind Permission of Landon Dyer
+// Source utilised with the kind permission of Landon Dyer
//
#include "riscasm.h"
+#include "amode.h"
+#include "direct.h"
#include "error.h"
-#include "sect.h"
-#include "token.h"
#include "expr.h"
-#include "direct.h"
#include "mark.h"
-#include "amode.h"
+#include "procln.h"
+#include "sect.h"
+#include "token.h"
-#define DEF_MR // Declar keyword values
-#include "risckw.h" // Incl generated risc keywords
+#define DEF_MR // Declare keyword values
+#include "risckw.h" // Incl. generated risc keywords
-#define DEF_KW // Declare keyword values
-#include "kwtab.h" // Incl generated keyword tables & defs
+#define DEF_KW // Declare keyword values
+#include "kwtab.h" // Incl. generated keyword tables & defs
unsigned altbankok = 0; // Ok to use alternate register bank
-unsigned orgactive = 0; // RISC org directive active
+unsigned orgactive = 0; // RISC/6502 org directive active
unsigned orgaddr = 0; // Org'd address
unsigned orgwarning = 0; // Has an ORG warning been issued
+int lastOpcode = -1; // Last RISC opcode assembled
+uint8_t riscImmTokenSeen; // The '#' (immediate) token was seen
-char reg_err[] = "missing register R0...R31";
+const char reg_err[] = "missing register R0...R31";
-// Jaguar Jump Condition Names
-char condname[MAXINTERNCC][5] = {
+// Jaguar jump condition names
+const char condname[MAXINTERNCC][5] = {
"NZ", "Z", "NC", "NCNZ", "NCZ", "C", "CNZ", "CZ", "NN", "NNNZ", "NNZ",
- "N", "N_NZ", "N_Z ", "T", "A", "NE", "EQ", "CC", "HS", "HI", "CS", "LO",
+ "N", "N_NZ", "N_Z", "T", "A", "NE", "EQ", "CC", "HS", "HI", "CS", "LO",
"PL", "MI", "F"
};
-// Jaguar Jump Condition Numbers
-char condnumber[] = {
+// Jaguar jump condition numbers
+const char condnumber[] = {
1, 2, 4, 5, 6, 8, 9, 10, 20, 21, 22, 24, 25, 26,
0, 0, 1, 2, 4, 4, 5, 8, 8, 20, 24, 31
};
-struct opcoderecord roptbl[] = {
+const struct opcoderecord roptbl[] = {
{ MR_ADD, RI_TWO, 0 },
{ MR_ADDC, RI_TWO, 1 },
{ MR_ADDQ, RI_NUM_32, 2 },
{ MR_NORMI, RI_TWO, 56 },
{ MR_NOP, RI_NONE, 57 },
{ MR_SAT24, RI_ONE, 62 },
- { MR_UNPACK, RI_ONE, 63 + GPUONLY },
- { MR_PACK, RI_ONE, 63 + GPUONLY },
+ { MR_UNPACK, RI_ONE, 63 + GPUONLY | (0 << 6) },
+ { MR_PACK, RI_ONE, 63 + GPUONLY | (1 << 6) },
{ MR_ADDQMOD, RI_NUM_32, 63 + DSPONLY },
{ MR_MOVE, RI_MOVE, 0 },
{ MR_LOAD, RI_LOAD, 0 },
//
-// Convert a String to Uppercase
+// Convert a string to uppercase
//
void strtoupper(char * s)
{
-#if 0
- while (*s)
- {
- *s = (char)(toupper(*s));
- s++;
- }
-#else
while (*s)
*s++ &= 0xDF;
-#endif
}
// Function to return "malformed expression" error
// This is done mainly to remove a bunch of GOTO statements in the parser
//
-static inline int MalformedOpcode(void)
+static inline int MalformedOpcode(int signal)
+{
+ return error("Malformed opcode [internal $%02X]", signal);
+}
+
+
+//
+// Function to return "Illegal Indexed Register" error
+// Anyone trying to index something other than R14 or R15
+//
+static inline int IllegalIndexedRegister(int reg)
{
- error("Malformed opcode");
- return ERROR;
+ return error("Attempted index reference with non-indexable register (r%d)", reg - KW_R0);
}
//
-// Build RISC Instruction Word
+// Function to return "Illegal Indexed Register" error for EQUR scenarios
+// Trying to use register value within EQUR that isn't 14 or 15
+//
+static inline int IllegalIndexedRegisterEqur(SYM * sy)
+{
+ return error("Attempted index reference with non-indexable register within EQUR (%s = r%d)", sy->sname, sy->svalue);
+}
+
+
+//
+// Build RISC instruction word
//
void BuildRISCIntructionWord(unsigned short opcode, int reg1, int reg2)
{
// Check for absolute address setting
if (!orgwarning && !orgactive)
{
- warn("GPU/DSP code outside of absolute section");
+ warn("RISC code generated with no origin defined");
orgwarning = 1;
}
int value = ((opcode & 0x3F) << 10) + ((reg1 & 0x1F) << 5) + (reg2 & 0x1F);
D_word(value);
+//printf("BuildRISC: opcode=$%X, reg1=$%X, reg2=$%X, final=$%04X\n", opcode, reg1, reg2, value);
}
//
-// Get a RISC Register
+// Get a RISC register
//
int GetRegister(WORD rattr)
{
- VALUE eval; // Expression value
+ uint64_t eval; // Expression value
WORD eattr; // Expression attributes
SYM * esym; // External symbol involved in expr.
TOKEN r_expr[EXPRSIZE]; // Expression token list
// Evaluate what's in the global "tok" buffer
if (expr(r_expr, &eval, &eattr, &esym) != OK)
- return MalformedOpcode();
+ return ERROR;
if ((challoc - ch_size) < 4)
chcheck(4L);
if (!(eattr & DEFINED))
{
- fixup((WORD)(FU_WORD | rattr), sloc, r_expr);
+ AddFixup((WORD)(FU_WORD | rattr), sloc, r_expr);
return 0;
}
// If we got a register in range (0-31), return it
- if ((eval >= 0) && (eval <= 31))
- return eval;
+ if (eval <= 31)
+ return (int)eval;
// Otherwise, it's out of range & we flag an error
- error(reg_err);
- return ERROR;
+ return error(reg_err);
}
//
-// Do RISC Code Generation
+// Do RISC code generation
//
int GenerateRISCCode(int state)
{
WORD attrflg;
int indexed; // Indexed register flag
- VALUE eval; // Expression value
+ uint64_t eval; // Expression value
WORD eattr; // Expression attributes
SYM * esym; // External symbol involved in expr.
TOKEN r_expr[EXPRSIZE]; // Expression token list
// Get opcode parameter and type
unsigned short parm = (WORD)(roptbl[state - 3000].parm);
unsigned type = roptbl[state - 3000].typ;
+ riscImmTokenSeen = 0; // Set to "token not seen yet"
// Detect whether the opcode parmeter passed determines that the opcode is
// specific to only one of the RISC processors and ensure it is legal in
// the current code section. If not then show error and return.
if (((parm & GPUONLY) && rdsp) || ((parm & DSPONLY) && rgpu))
- {
- error("Opcode is not valid in this code section");
- return ERROR;
- }
+ return error("Opcode is not valid in this code section");
// Process RISC opcode
switch (type)
{
// No operand instructions
- // NOP
- case RI_NONE:
+ // NOP (57)
+ case RI_NONE:
BuildRISCIntructionWord(parm, 0, 0);
break;
// Single operand instructions (Rd)
- // ABS, MIRROR, NEG, NOT, PACK, RESMAC, SAT8, SAT16, SAT16S, SAT24, SAT32S, UNPACK
+ // ABS, MIRROR, NEG, NOT, PACK, RESMAC, SAT8, SAT16, SAT16S, SAT24, SAT32S,
+ // UNPACK
case RI_ONE:
reg2 = GetRegister(FU_REGTWO);
at_eol();
BuildRISCIntructionWord(parm, parm >> 6, reg2);
- break;
+ break;
// Two operand instructions (Rs,Rd)
- // ADD, ADDC, AND, CMP, DIV, IMACN, IMULT, IMULTN, MOVEFA, MOVETA, MULT, MMULT,
- // MTOI, NORMI, OR, ROR, SH, SHA, SUB, SUBC, XOR
- case RI_TWO:
+ // ADD, ADDC, AND, CMP, DIV, IMACN, IMULT, IMULTN, MOVEFA, MOVETA, MULT,
+ // MMULT, MTOI, NORMI, OR, ROR, SH, SHA, SUB, SUBC, XOR
+ case RI_TWO:
if (parm == 37)
altbankok = 1; // MOVEFA
reg1 = GetRegister(FU_REGONE);
- CHECK_COMMA;
+ CHECK_COMMA;
if (parm == 36)
altbankok = 1; // MOVETA
case RI_NUM_31:
// Numeric operand (n,Rd) where n = 1..32
- // ADDQ, ADDQMOD, ADDQT, SHARQ, SHLQ, SHRQ, SUBQ, SUBQMOD, SUBQT, ROLQ, RORQ
+ // ADDQ, ADDQMOD, ADDQT, SHARQ, SHLQ, SHRQ, SUBQ, SUBQMOD, SUBQT, ROLQ,
+ // RORQ
case RI_NUM_32:
switch (type)
{
attrflg |= FU_SUB32;
if (*tok != '#')
- return MalformedOpcode();
+ return MalformedOpcode(0x01);
tok++;
+ riscImmTokenSeen = 1;
if (expr(r_expr, &eval, &eattr, &esym) != OK)
- return MalformedOpcode();
+ return MalformedOpcode(0x02);
if ((challoc - ch_size) < 4)
chcheck(4L);
if (!(eattr & DEFINED))
{
- fixup((WORD)(FU_WORD | attrflg), sloc, r_expr);
+ AddFixup((WORD)(FU_WORD | attrflg), sloc, r_expr);
reg1 = 0;
}
else
{
if ((int)eval < reg1 || (int)eval > reg2)
- {
- error("constant out of range");
- return ERROR;
- }
+ return error("constant out of range");
- if (parm & SUB32)
- reg1 = 32 - eval;
+ if (parm & SUB32)
+ reg1 = 32 - (int)eval;
else if (type == RI_NUM_32)
- reg1 = (reg1 == 32 ? 0 : eval);
+ reg1 = (reg1 == 32 ? 0 : (int)eval);
else
- reg1 = eval;
+ reg1 = (int)eval;
}
CHECK_COMMA;
// Move Immediate--n,Rn--n in Second Word
case RI_MOVEI:
if (*tok != '#')
- return MalformedOpcode();
+ return MalformedOpcode(0x03);
tok++;
+ riscImmTokenSeen = 1;
+
+ // Check for equated register after # and return error if so
+ if (*tok == SYMBOL)
+ {
+ sy = lookup(string[tok[1]], LABEL, 0);
+
+ if (sy && (sy->sattre & EQUATEDREG))
+ return error("equated register in 1st operand of MOVEI instruction");
+ }
if (expr(r_expr, &eval, &eattr, &esym) != OK)
- return MalformedOpcode();
+ return MalformedOpcode(0x04);
+
+ if (lastOpcode == RI_JUMP || lastOpcode == RI_JR)
+ {
+ if (legacy_flag)
+ {
+ // User doesn't care, emit a NOP to fix
+ BuildRISCIntructionWord(57, 0, 0);
+ warn("MOVEI following JUMP, inserting NOP to fix your BROKEN CODE");
+ }
+ else
+ warn("MOVEI immediately follows JUMP");
+ }
if ((challoc - ch_size) < 4)
chcheck(4L);
if (!(eattr & DEFINED))
{
- fixup(FU_LONG | FU_MOVEI, sloc + 2, r_expr);
+ AddFixup(FU_LONG | FU_MOVEI, sloc + 2, r_expr);
eval = 0;
}
else
{
if (eattr & TDB)
//{
-//printf("risca: Doing rmark for RI_MOVEI (tdb=$%X)...\n", eattr & TDB);
- rmark(cursect, sloc + 2, (eattr & TDB), (MLONG | MMOVEI), NULL);
+//printf("RISCASM: Doing MarkRelocatable for RI_MOVEI (tdb=$%X)...\n", eattr & TDB);
+ MarkRelocatable(cursect, sloc + 2, (eattr & TDB), (MLONG | MMOVEI), NULL);
//}
}
- val = ((eval >> 16) & 0x0000FFFF) | ((eval << 16) & 0xFFFF0000);
+// val = ((eval >> 16) & 0x0000FFFF) | ((eval << 16) & 0xFFFF0000);
+ val = WORDSWAP32(eval);
CHECK_COMMA;
reg2 = GetRegister(FU_REGTWO);
at_eol();
break;
// (Rn),Rn = 41 / (R14/R15+n),Rn = 43/44 / (R14/R15+Rn),Rn = 58/59
- case RI_LOAD:
+ case RI_LOAD:
indexed = 0;
parm = 41;
if (*tok != '(')
- return MalformedOpcode();
+ return MalformedOpcode(0x05);
tok++;
- if ((*tok == KW_R14 || *tok == KW_R15) && (*(tok + 1) != ')'))
- indexed = (*tok - KW_R0);
+ if ((*(tok + 1) == '+') || (*(tok + 1) == '-')) {
+ // Trying to make indexed call
+ if ((*tok == KW_R14 || *tok == KW_R15)) {
+ indexed = (*tok - KW_R0);
+ } else {
+ return IllegalIndexedRegister(*tok);
+ }
+ }
if (*tok == SYMBOL)
{
if (sy->sattre & EQUATEDREG)
{
- if (((sy->svalue & 0x1F) == 14 || (sy->svalue & 0x1F) == 15)
- && (*(tok + 2) != ')'))
- {
- indexed = (sy->svalue & 0x1F);
- tok++;
+ if ((*(tok + 2) == '+') || (*(tok + 2) == '-')) {
+ if ((sy->svalue & 0x1F) == 14 || (sy->svalue & 0x1F) == 15) {
+ indexed = (sy->svalue & 0x1F);
+ tok++;
+ } else {
+ return IllegalIndexedRegisterEqur(sy);
+ }
}
}
}
else
{
if (expr(r_expr, &eval, &eattr, &esym) != OK)
- return MalformedOpcode();
+ return MalformedOpcode(0x06);
if ((challoc - ch_size) < 4)
chcheck(4L);
if (!(eattr & DEFINED))
- {
- error("constant expected");
- return ERROR;
- }
+ return error("constant expected after '+'");
- reg1 = eval;
+ reg1 = (int)eval;
if (reg1 == 0)
{
reg1 = 14 + (parm - 58);
parm = 41;
- warn("NULL offset removed");
+ warn("NULL offset in LOAD ignored");
}
else
{
if (reg1 < 1 || reg1 > 32)
- {
- error("constant out of range");
- return ERROR;
- }
+ return error("constant in LOAD out of range");
if (reg1 == 32)
reg1 = 0;
}
if (*tok != ')')
- return MalformedOpcode();
+ return MalformedOpcode(0x07);
tok++;
CHECK_COMMA;
break;
// Rn,(Rn) = 47 / Rn,(R14/R15+n) = 49/50 / Rn,(R14/R15+Rn) = 60/61
- case RI_STORE:
+ case RI_STORE:
parm = 47;
reg1 = GetRegister(FU_REGONE);
CHECK_COMMA;
if (*tok != '(')
- return MalformedOpcode();
+ return MalformedOpcode(0x08);
tok++;
indexed = 0;
- if ((*tok == KW_R14 || *tok == KW_R15) && (*(tok + 1) != ')'))
+ if ((*tok == KW_R14 || *tok == KW_R15) && (*(tok + 1) != ')'))
indexed = (*tok - KW_R0);
if (*tok == SYMBOL)
{
-// sy = lookup((char *)tok[1], LABEL, 0);
sy = lookup(string[tok[1]], LABEL, 0);
if (!sy)
return ERROR;
}
- if (sy->sattre & EQUATEDREG)
+ if (sy->sattre & EQUATEDREG)
{
if (((sy->svalue & 0x1F) == 14 || (sy->svalue & 0x1F) == 15)
&& (*(tok + 2) != ')'))
if (*tok == SYMBOL)
{
-// sy = lookup((char *)tok[1], LABEL, 0);
sy = lookup(string[tok[1]], LABEL, 0);
if (!sy)
else
{
if (expr(r_expr, &eval, &eattr, &esym) != OK)
- return MalformedOpcode();
+ return MalformedOpcode(0x09);
if ((challoc - ch_size) < 4)
chcheck(4L);
if (!(eattr & DEFINED))
{
- fixup(FU_WORD | FU_REGTWO, sloc, r_expr);
+ AddFixup(FU_WORD | FU_REGTWO, sloc, r_expr);
reg2 = 0;
}
else
{
- reg2 = eval;
+ reg2 = (int)eval;
if (reg2 == 0)
{
reg2 = 14 + (parm - 60);
parm = 47;
- warn("NULL offset removed");
+ warn("NULL offset in STORE ignored");
}
else
{
if (reg2 < 1 || reg2 > 32)
- {
- error("constant out of range");
- return ERROR;
- }
+ return error("constant in STORE out of range");
if (reg2 == 32)
reg2 = 0;
}
if (*tok != ')')
- return MalformedOpcode();
+ return MalformedOpcode(0x0A);
tok++;
at_eol();
break;
// LOADB/LOADP/LOADW (Rn),Rn
- case RI_LOADN:
+ case RI_LOADN:
if (*tok != '(')
- return MalformedOpcode();
+ return MalformedOpcode(0x0B);
tok++;
reg1 = GetRegister(FU_REGONE);
if (*tok != ')')
- return MalformedOpcode();
+ return MalformedOpcode(0x0C);
tok++;
CHECK_COMMA;
break;
// STOREB/STOREP/STOREW Rn,(Rn)
- case RI_STOREN:
+ case RI_STOREN:
reg1 = GetRegister(FU_REGONE);
CHECK_COMMA;
if (*tok != '(')
- return MalformedOpcode();
+ return MalformedOpcode(0x0D);
tok++;
reg2 = GetRegister(FU_REGTWO);
if (*tok != ')')
- return MalformedOpcode();
+ return MalformedOpcode(0x0E);
tok++;
at_eol();
{
// CC using a constant number
tok++;
- val = *tok;
- tok++;
+ uint64_t *tok64 = (uint64_t *)tok;
+ val = (int)*tok64++;
+ tok = (uint32_t *)tok64;
CHECK_COMMA;
}
else if (*tok == SYMBOL)
ccsym = lookup(string[tok[1]], LABEL, 0);
if (ccsym && (ccsym->sattre & EQUATEDCC) && !(ccsym->sattre & UNDEF_CC))
- {
- val = ccsym->svalue;
- }
+ val = (int)ccsym->svalue;
else
- {
- error("unknown condition code");
- return ERROR;
- }
+ return error("unknown condition code");
}
tok += 2;
}
if (val < 0 || val > 31)
- {
- error("condition constant out of range");
- return ERROR;
- }
+ return error("condition constant out of range");
// Store condition code
reg1 = val;
{
// JR cc,n
if (expr(r_expr, &eval, &eattr, &esym) != OK)
- return MalformedOpcode();
+ return MalformedOpcode(0x0F);
if ((challoc - ch_size) < 4)
chcheck(4L);
if (!(eattr & DEFINED))
{
- fixup(FU_WORD | FU_JR, sloc, r_expr);
+ AddFixup(FU_WORD | FU_JR, sloc, r_expr);
reg2 = 0;
}
else
reg2 = ((int)(eval - ((orgactive ? orgaddr : sloc) + 2))) / 2;
if ((reg2 < -16) || (reg2 > 15))
- error("PC relative overflow");
+ error("PC relative overflow (outside of -16 to 15)");
}
BuildRISCIntructionWord(parm, reg2, reg1);
{
// JUMP cc, (Rn)
if (*tok != '(')
- return MalformedOpcode();
+ return MalformedOpcode(0x10);
tok++;
reg2 = GetRegister(FU_REGTWO);
if (*tok != ')')
- return MalformedOpcode();
+ return MalformedOpcode(0x11);
tok++;
at_eol();
// Should never get here :-D
default:
- error("Unknown risc opcode type");
- return ERROR;
+ return error("Unknown RISC opcode type");
}
+ lastOpcode = type;
return 0;
}
projects / rmac / blobdiff