]> Shamusworld >> Repos - rmac/blobdiff - direct.c
Fix for bug #29.
[rmac] / direct.c
index 100db425f7afe7bad4fad3a0e5e64603fcfbb587..77fda019a62dd459a106f98959aac8be486a769b 100644 (file)
--- a/direct.c
+++ b/direct.c
@@ -8,7 +8,7 @@
 
 #include "direct.h"
 #include "sect.h"
-#include "risca.h"
+#include "riscasm.h"
 #include "error.h"
 #include "token.h"
 #include "procln.h"
 #define DEF_KW
 #include "kwtab.h"
 
+
 TOKEN exprbuf[128];                    // Expression buffer 
 SYM * symbolPtr[1000000];      // Symbol pointers table
+static long unused;                    // For supressing 'write' warnings
+
 
 // Directive handler table
 int (*dirtab[])() = {
-   d_org,                              // 0 org
-   d_even,                             // 1 even
-   d_unimpl,                   // 2 .6502
-   d_68000,                            // 3 .68000 
-   d_bss,                              // 4 bss
-   d_data,                             // 5 data 
-   d_text,                             // 6 text 
-   d_abs,                              // 7 abs 
-   d_comm,                             // 8 comm 
-   d_init,                             // 9 init 
-   d_cargs,                            // 10 cargs 
-   d_goto,                             // 11 goto 
-   d_dc,                               // 12 dc 
-   d_ds,                               // 13 ds 
-   d_undmac,                   // 14 undefmac 
-   d_gpu,                              // 15 .gpu
-   d_dsp,                              // 16 .dsp
-   d_dcb,                              // 17 dcb 
-   d_unimpl,                   // 18* set 
-   d_unimpl,                   // 19* reg 
-   d_unimpl,                   // 20 dump 
-   d_incbin,                   // 21 .incbin //load 
-   d_unimpl,                   // 22 disable 
-   d_unimpl,                   // 23 enable 
-   d_globl,                            // 24 globl 
-   d_regbank0,                 // 25 .regbank0
-   d_regbank1,                 // 26 .regbank1
-   d_unimpl,                   // 27 xdef 
-   d_assert,                   // 28 assert 
-   d_unimpl,                   // 29* if 
-   d_unimpl,                   // 30* endif 
-   d_unimpl,                   // 31* endc 
-   d_unimpl,                   // 32* iif 
-   d_include,                  // 33 include 
-   fpop,                               // 34 end 
-   d_unimpl,                   // 35* macro 
-   ExitMacro,                  // 36* exitm 
-   d_unimpl,                   // 37* endm 
-   d_list,                             // 38 list 
-   d_nlist,                            // 39 nlist 
-   d_long,                             // 40* rept 
-   d_phrase,                   // 41* endr 
-   d_dphrase,                  // 42 struct 
-   d_qphrase,                  // 43 ends 
-   d_title,                            // 44 title 
-   d_subttl,                   // 45 subttl 
-   eject,                              // 46 eject 
-   d_unimpl,                   // 47 error 
-   d_unimpl,                   // 48 warn 
-   d_noclear,                  // 49 .noclear
-   d_equrundef,                        // 50 .equrundef/.regundef
-   d_ccundef,                  // 51 .ccundef
-   d_print,                            // 52 .print
-   d_cstruct,                  // 53 .cstruct
+       d_org,                          // 0 org
+       d_even,                         // 1 even
+       d_unimpl,                       // 2 .6502
+       d_68000,                        // 3 .68000 
+       d_bss,                          // 4 bss
+       d_data,                         // 5 data 
+       d_text,                         // 6 text 
+       d_abs,                          // 7 abs 
+       d_comm,                         // 8 comm 
+       d_init,                         // 9 init 
+       d_cargs,                        // 10 cargs 
+       d_goto,                         // 11 goto 
+       d_dc,                           // 12 dc 
+       d_ds,                           // 13 ds 
+       d_undmac,                       // 14 undefmac 
+       d_gpu,                          // 15 .gpu
+       d_dsp,                          // 16 .dsp
+       d_dcb,                          // 17 dcb 
+       d_unimpl,                       // 18* set 
+       d_unimpl,                       // 19* reg 
+       d_unimpl,                       // 20 dump 
+       d_incbin,                       // 21 .incbin //load 
+       d_unimpl,                       // 22 disable 
+       d_unimpl,                       // 23 enable 
+       d_globl,                        // 24 globl 
+       d_regbank0,                     // 25 .regbank0
+       d_regbank1,                     // 26 .regbank1
+       d_unimpl,                       // 27 xdef 
+       d_assert,                       // 28 assert 
+       d_unimpl,                       // 29* if 
+       d_unimpl,                       // 30* endif 
+       d_unimpl,                       // 31* endc 
+       d_unimpl,                       // 32* iif 
+       d_include,                      // 33 include 
+       fpop,                           // 34 end 
+       d_unimpl,                       // 35* macro 
+       ExitMacro,                      // 36* exitm 
+       d_unimpl,                       // 37* endm 
+       d_list,                         // 38 list 
+       d_nlist,                        // 39 nlist 
+       d_long,                         // 40* rept 
+       d_phrase,                       // 41* endr 
+       d_dphrase,                      // 42 struct 
+       d_qphrase,                      // 43 ends 
+       d_title,                        // 44 title 
+       d_subttl,                       // 45 subttl 
+       eject,                          // 46 eject 
+       d_unimpl,                       // 47 error 
+       d_unimpl,                       // 48 warn 
+       d_noclear,                      // 49 .noclear
+       d_equrundef,            // 50 .equrundef/.regundef
+       d_ccundef,                      // 51 .ccundef
+       d_print,                        // 52 .print
+       d_cstruct,                      // 53 .cstruct
+       d_jpad,                         // 54 .jpad (deprecated)
+       d_nojpad,                       // 55 .nojpad (deprecated)
+       d_gpumain,                      // 56 .gpumain (deprecated)
 };
 
 
@@ -102,7 +108,8 @@ int d_org(void)
        }
 
        orgaddr = address;
-       orgactive = 1;  
+       orgactive = 1;
+//printf("ORG: address = $%08X...\n", orgaddr);
 
        return 0;
 }
@@ -113,15 +120,15 @@ int d_org(void)
 //
 int d_print(void)
 {
-       char prntstr[LNSIZ];                                     // String for PRINT directive
-       char format[LNSIZ];                                      // Format for PRINT directive
-       int formatting = 0;                                      // Formatting on/off
-       int wordlong = 0;                                        // WORD = 0, LONG = 1
-       int outtype = 0;                                         // 0:hex, 1:decimal, 2:unsigned
-
-       VALUE eval;                                              // Expression value
-       WORD eattr;                                              // Expression attributes
-       SYM * esym;                                              // External symbol involved in expr.
+       char prntstr[LNSIZ];                                    // String for PRINT directive
+       char format[LNSIZ];                                             // Format for PRINT directive
+       int formatting = 0;                                             // Formatting on/off
+       int wordlong = 0;                                               // WORD = 0, LONG = 1
+       int outtype = 0;                                                // 0:hex, 1:decimal, 2:unsigned
+
+       VALUE eval;                                                             // Expression value
+       WORD eattr;                                                             // Expression attributes
+       SYM * esym;                                                             // External symbol involved in expr.
        TOKEN r_expr[EXPRSIZE];
 
        while (*tok != EOL)
@@ -134,7 +141,7 @@ int d_print(void)
                        printf("%s", prntstr);
 
                        if (list_fd) 
-                               write(list_fd, prntstr, (LONG)strlen(prntstr));
+                               unused = write(list_fd, prntstr, (LONG)strlen(prntstr));
 
                        tok += 2;
                        break;
@@ -184,7 +191,7 @@ int d_print(void)
                                printf("%s", prntstr);
 
                                if (list_fd) 
-                                       write(list_fd, prntstr, (LONG)strlen(prntstr));
+                                       unused = write(list_fd, prntstr, (LONG)strlen(prntstr));
 
                                formatting = 0;
                                wordlong = 0;
@@ -196,7 +203,7 @@ int d_print(void)
        }
 
        printf("\n");
-       println("\n");
+//     println("\n");
 
        return 0;
 
@@ -222,7 +229,8 @@ int d_ccundef(void)
 
        if (*tok != SYMBOL)
        {
-               error(syntax_error);
+//             error(syntax_error);
+               error("syntax error; expected symbol");
                return ERROR;
        }
 
@@ -251,26 +259,19 @@ int d_equrundef(void)
 
        // Check that we are in a RISC section
        if (!rgpu && !rdsp)
-       {
-               error(".equrundef/.regundef must be defined in .gpu/.dsp section");
-               return ERROR;
-       }
+               return error(".equrundef/.regundef must be defined in .gpu/.dsp section");
 
        while (*tok != EOL)
        {
-               // Skip preceeding or seperating commas
+               // Skip preceeding or seperating commas (if any)
                if (*tok == ',')
                        tok++;
 
                // Check we are dealing with a symbol
                if (*tok != SYMBOL)
-               {
-                       error(syntax_error);
-                       return ERROR;
-               }
+                       return error("syntax error; expected symbol");
 
                // Lookup and undef if equated register
-//             regname = lookup((char *)tok[1], LABEL, 0);
                regname = lookup(string[tok[1]], LABEL, 0);
 
                if (regname && (regname->sattre & EQUATEDREG))
@@ -312,35 +313,10 @@ int d_incbin(void)
 
        if (*tok != STRING)
        {
-               error(syntax_error);
+               error("syntax error; string missing");
                return ERROR;
        }
 
-#if 0
-       if ((j = open(string[tok[1]],  _OPEN_INC)) >= 0)
-       {
-               size = lseek(j, 0L, SEEK_END);
-               chcheck(size);
-               pos = lseek(j, 0L, SEEK_SET);
-
-               DEBUG
-               {
-                       printf("INCBIN: File '%s' is %li bytes.\n", string[tok[1]], size);
-               }
-
-               for(i=0; i<size; i++)
-               {
-                       buf = '\0';
-                       bytes = read(j, &buf, 1);
-                       D_byte(buf);
-               }
-       }
-       else
-       {
-               errors("cannot open include binary file (%s)", string[tok[1]]);
-               return ERROR;
-       }
-#else
        if ((fd = open(string[tok[1]],  _OPEN_INC)) < 0)
        {
                errors("cannot open include binary file (%s)", string[tok[1]]);
@@ -351,19 +327,8 @@ int d_incbin(void)
        pos = lseek(fd, 0L, SEEK_SET);
        chcheck(size);
 
-       DEBUG
-       {
-               printf("INCBIN: File '%s' is %li bytes.\n", string[tok[1]], size);
-       }
+       DEBUG { printf("INCBIN: File '%s' is %li bytes.\n", string[tok[1]], size); }
 
-#if 0
-       for(i=0; i<size; i++)
-       {
-               buf = '\0';
-               bytes = read(j, &buf, 1);
-               D_byte(buf);
-       }
-#else
        char * fileBuffer = (char *)malloc(size);
        bytesRead = read(fd, fileBuffer, size);
 
@@ -374,7 +339,6 @@ int d_incbin(void)
                return ERROR;
        }
 
-//#define D_byte(b)    {*chptr++=(char)b; ++sloc; ++ch_size; if(orgactive) ++orgaddr;}
        memcpy(chptr, fileBuffer, size);
        chptr += size;
        sloc += size;
@@ -384,9 +348,6 @@ int d_incbin(void)
                orgaddr += size;
 
        free(fileBuffer);
-#endif
-#endif
-
        close(fd);
        return 0;
 }
@@ -411,12 +372,38 @@ int d_regbank1(void)
 }
 
 
+//
+// Helper function, to cut down on mistakes & typing
+//
+static inline void SkipBytes(unsigned bytesToSkip)
+{
+       if (!bytesToSkip)
+               return;
+
+       if ((scattr & SBSS) == 0)
+       {
+               chcheck(bytesToSkip);
+               D_ZEROFILL(bytesToSkip);
+       }
+       else
+       {
+               sloc += bytesToSkip;
+
+               if (orgactive)
+                       orgaddr += bytesToSkip;
+       }
+}
+
+
 //
 // Adjust Location to an EVEN Value
 //
 int d_even(void)
 {
-       if (sloc & 1)
+       unsigned skip = (rgpu || rdsp ? orgaddr : sloc) & 0x01;
+       
+//     if (sloc & 1)
+       if (skip)
        {
                if ((scattr & SBSS) == 0)
                {
@@ -425,7 +412,10 @@ int d_even(void)
                }
                else
                {
-                       ++sloc;
+                       sloc++;
+
+                       if (orgactive)
+                               orgaddr++;
                }
        }
 
@@ -438,30 +428,9 @@ int d_even(void)
 //
 int d_long(void)
 {
-       unsigned i;
-       unsigned val = 4;
-                       
-       i = sloc & ~(val - 1);
-
-       if (i != sloc)
-               val = val - (sloc - i); 
-       else
-               val = 0;
-
-       if (val)
-       {
-               if ((scattr & SBSS) == 0)
-               {
-                       chcheck(val);
-
-                       for(i=0; i<val; i++) 
-                               D_byte(0);
-               }
-               else
-               {
-                       sloc += val;
-               }
-       }
+       unsigned lower2Bits = (rgpu || rdsp ? orgaddr : sloc) & 0x03;
+       unsigned bytesToSkip = (0x04 - lower2Bits) & 0x03;
+       SkipBytes(bytesToSkip);
 
        return 0;
 }
@@ -470,32 +439,20 @@ int d_long(void)
 //
 // Adjust Location to an PHRASE Value
 //
+// N.B.: We have to handle the GPU/DSP cases separately because you can embed
+//       RISC code in the middle of a regular 68K section. Also note that all
+//       of the alignment pseudo-ops will have to be fixed this way.
+//
+// This *must* behave differently when in a RISC section, as following sloc
+// (instead of orgaddr) will fuck things up royally. Note that we do it this
+// way because you can embed RISC code in a 68K section, and have the origin
+// pointing to a different alignment in the RISC section than the 68K section.
+//
 int d_phrase(void)
 {
-       unsigned i;
-       unsigned val = 8;
-                       
-       i = sloc & ~(val - 1);
-
-       if (i != sloc)
-               val = val - (sloc - i); 
-       else
-               val = 0;
-
-       if (val)
-       {
-               if ((scattr & SBSS) == 0)
-               {
-                       chcheck(val);
-
-                       for(i=0; i<val; i++) 
-                               D_byte(0);
-               }
-               else
-               {
-                       sloc += val;
-               }
-       }
+       unsigned lower3Bits = (rgpu || rdsp ? orgaddr : sloc) & 0x07;
+       unsigned bytesToSkip = (0x08 - lower3Bits) & 0x07;
+       SkipBytes(bytesToSkip);
 
        return 0;
 }
@@ -506,30 +463,9 @@ int d_phrase(void)
 //
 int d_dphrase(void)
 {
-       unsigned i;
-       unsigned val = 16;
-                       
-       i = sloc & ~(val - 1);
-
-       if (i != sloc)
-               val = val - (sloc - i); 
-       else
-               val = 0;
-
-       if (val)
-       {
-               if ((scattr & SBSS) == 0)
-               {
-                       chcheck(val);
-
-                       for(i=0; i<val; i++) 
-                               D_byte(0);
-               }
-               else
-               {
-                       sloc += val;
-               }
-       }
+       unsigned lower4Bits = (rgpu || rdsp ? orgaddr : sloc) & 0x0F;
+       unsigned bytesToSkip = (0x10 - lower4Bits) & 0x0F;
+       SkipBytes(bytesToSkip);
 
        return 0;
 }
@@ -540,31 +476,9 @@ int d_dphrase(void)
 //
 int d_qphrase(void)
 {
-       unsigned i;
-       unsigned val = 32;
-                       
-       i = sloc & ~(val - 1);
-
-       if (i != sloc)
-               val = val - (sloc - i); 
-       else
-               val = 0;
-
-       if (val)
-       {
-               if ((scattr & SBSS) == 0)
-               {
-                       savsect();
-                       chcheck(val);
-
-                       for(i=0; i<val; i++) 
-                               D_byte(0);
-               }
-               else
-               {
-                       sloc += val;
-               }
-       }
+       unsigned lower5Bits = (rgpu || rdsp ? orgaddr : sloc) & 0x1F;
+       unsigned bytesToSkip = (0x20 - lower5Bits) & 0x1F;
+       SkipBytes(bytesToSkip);
 
        return 0;
 }
@@ -578,14 +492,16 @@ int d_qphrase(void)
 // which is OK since multiple labels are only allowed in AS68 kludge mode, and
 // the C compiler is VERY paranoid and uses ".even" whenever it can
 //
+// N.B.: This probably needs the same fixes as above...
+//
 void auto_even(void)
 {
        if (scattr & SBSS)
-               ++sloc;                                               // Bump BSS section
+               sloc++;                           // Bump BSS section
        else
-               D_byte(0)                                             // Deposit 0.b in non-BSS
+               D_byte(0);                        // Deposit 0.b in non-BSS
 
-       if (lab_sym != NULL)                                      // Bump label if we have to
+       if (lab_sym != NULL)                  // Bump label if we have to
                ++lab_sym->svalue;
 }
 
@@ -624,18 +540,14 @@ int abs_expr(VALUE * a_eval)
 //
 int symlist(int(* func)())
 {
-       char * em = "symbol list syntax";
+       const char * em = "symbol list syntax";
 
        for(;;)
        {
                if (*tok != SYMBOL)
                        return error(em);
 
-#if 0
-               if ((*func)(tok[1]) != OK)
-#else
                if ((*func)(string[tok[1]]) != OK)
-#endif
                        break;
 
                tok += 2;
@@ -646,7 +558,7 @@ int symlist(int(* func)())
                if (*tok != ',')
                        return error(em);
 
-               ++tok;
+               tok++;
        }
 
        return 0;
@@ -745,7 +657,7 @@ int d_assert(void)
 //
 int globl1(char * p)
 {
-       SYM *sy;
+       SYM * sy;
 
        if (*p == '.')
                return error("cannot .globl local symbol");
@@ -755,6 +667,7 @@ int globl1(char * p)
                sy = NewSymbol(p, LABEL, 0);
                sy->svalue = 0;
                sy->sattr = GLOBAL;
+//printf("glob1: Making global symbol: attr=%04X, eattr=%08X, %s\n", sy->sattr, sy->sattre, sy->sname);
        }
        else 
                sy->sattr |= GLOBAL;
@@ -777,14 +690,14 @@ int d_abs(void)
 {
        VALUE eval;
 
-       savsect();
+       SaveSection();
 
        if (*tok == EOL)
                eval = 0;
        else if (abs_expr(&eval) != OK)
                return 0;
 
-       switchsect(ABS);
+       SwitchSection(ABS);
        sloc = eval;
        return 0;
 }
@@ -801,8 +714,8 @@ int d_text(void)
 
        if (cursect != TEXT)
        {
-               savsect();
-               switchsect(TEXT);
+               SaveSection();
+               SwitchSection(TEXT);
        }
 
        return 0;
@@ -816,8 +729,8 @@ int d_data(void)
 
        if (cursect != DATA)
        {
-               savsect();
-               switchsect(DATA);
+               SaveSection();
+               SwitchSection(DATA);
        }
 
        return 0;
@@ -831,8 +744,8 @@ int d_bss(void)
 
        if (cursect != BSS)
        {
-               savsect();
-               switchsect(BSS);
+               SaveSection();
+               SwitchSection(BSS);
        }
 
        return 0;
@@ -941,7 +854,7 @@ int d_dc(WORD siz)
                case SIZB:
                        if (!defined)
                        {
-                               fixup(FU_BYTE | FU_SEXT, sloc, exprbuf);
+                               AddFixup(FU_BYTE | FU_SEXT, sloc, exprbuf);
                                D_byte(0);
                        }
                        else
@@ -960,7 +873,7 @@ int d_dc(WORD siz)
                case SIZN:
                        if (!defined)
                        {
-                               fixup(FU_WORD | FU_SEXT, sloc, exprbuf);
+                               AddFixup(FU_WORD | FU_SEXT, sloc, exprbuf);
                                D_word(0);
                        }
                        else
@@ -980,9 +893,9 @@ int d_dc(WORD siz)
                        if (!defined)
                        {
                                if (movei)
-                                       fixup(FU_LONG | FU_MOVEI, sloc, exprbuf);
+                                       AddFixup(FU_LONG | FU_MOVEI, sloc, exprbuf);
                                else
-                                       fixup(FU_LONG, sloc, exprbuf);
+                                       AddFixup(FU_LONG, sloc, exprbuf);
 
                                D_long(0);
                        }
@@ -1128,7 +1041,7 @@ int dep_block(VALUE count, WORD siz, VALUE eval, WORD eattr, TOKEN * exprbuf)
                case SIZB:
                        if (!defined)
                        {
-                               fixup(FU_BYTE | FU_SEXT, sloc, exprbuf);
+                               AddFixup(FU_BYTE | FU_SEXT, sloc, exprbuf);
                                D_byte(0);
                        }
                        else
@@ -1147,7 +1060,7 @@ int dep_block(VALUE count, WORD siz, VALUE eval, WORD eattr, TOKEN * exprbuf)
                case SIZN:
                        if (!defined)
                        {
-                               fixup(FU_WORD | FU_SEXT, sloc, exprbuf);
+                               AddFixup(FU_WORD | FU_SEXT, sloc, exprbuf);
                                D_word(0);
                        }
                        else
@@ -1166,7 +1079,7 @@ int dep_block(VALUE count, WORD siz, VALUE eval, WORD eattr, TOKEN * exprbuf)
                case SIZL:
                        if (!defined)
                        {
-                               fixup(FU_LONG, sloc, exprbuf);
+                               AddFixup(FU_LONG, sloc, exprbuf);
                                D_long(0);
                        }
                        else
@@ -1259,8 +1172,8 @@ int d_68000(void)
        // Switching from gpu/dsp sections should reset any ORG'd Address
        orgactive = 0;                               
        orgwarning = 0;
-       savsect();
-       switchsect(TEXT);
+       SaveSection();
+       SwitchSection(TEXT);
        return 0;
 }
 
@@ -1279,9 +1192,11 @@ int d_gpu(void)
        // If previous section was dsp or 68000 then we need to reset ORG'd Addresses
        if (!rgpu)
        {
+//printf("Resetting ORG...\n");
                orgactive = 0;
                orgwarning = 0;
        }
+//else printf("NOT resetting ORG!\n");
 
        rgpu = 1;                       // Set GPU assembly
        rdsp = 0;                       // Unset DSP assembly
@@ -1378,7 +1293,7 @@ int d_cargs(void)
 
                        // Put symbol in "order of definition" list
                        if (!(symbol->sattr & SDECLLIST))
-                               sym_decl(symbol);
+                               AddToSymbolOrderList(symbol);
 
                        symbol->sattr |= (ABS | DEFINED | EQUATED);
                        symbol->svalue = eval;
@@ -1496,7 +1411,7 @@ int d_cstruct(void)
 
                        // Put symbol in "order of definition" list
                        if (!(symbol->sattr & SDECLLIST))
-                               sym_decl(symbol);
+                               AddToSymbolOrderList(symbol);
 
                        tok += 2;
 
@@ -1593,3 +1508,23 @@ int d_undmac(void)
        return 0;
 }
 
+
+int d_jpad(void)
+{
+       warn("JPAD directive is deprecated/non-functional");
+       return OK;
+}
+
+
+int d_nojpad(void)
+{
+       warn("NOJPAD directive is deprecated/non-functional");
+       return OK;
+}
+
+
+int d_gpumain(void)
+{
+       return error("What the hell? Do you think we adhere to the Goof standard?");
+}
+