X-Git-Url: http://shamusworld.gotdns.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fvector.cpp;h=20b8ef5f99e5bde36b6020120042d4691a1f222b;hb=6114b754fcd6e7d83c71dc2fa0ef2ec185387e12;hp=53c6bfef4ab0d49e25c5baf0a18bb56569aa86ac;hpb=acd27aa62a4c78b6aeee523e3145a8aa53f4bcde;p=architektonas diff --git a/src/vector.cpp b/src/vector.cpp index 53c6bfe..20b8ef5 100644 --- a/src/vector.cpp +++ b/src/vector.cpp @@ -194,7 +194,8 @@ Vector Vector::Unit(void) { double mag = Magnitude(); - // If the magnitude of the vector is zero, then the Unit vector is undefined... + // If the magnitude of the vector is zero, then the Unit vector is + // undefined... if (mag == 0) return Vector(0, 0, 0); @@ -210,15 +211,11 @@ double Vector::Magnitude(void) double Vector::Angle(void) { - // acos returns a value between zero and PI, which means we don't know which - // quadrant the angle is in... Though, if the y-coordinate of the vector is - // negative, that means that the angle is in quadrants III - IV. + // acos returns a value between zero and TAU/2, which means we don't know + // which quadrant the angle is in... However, if the y-coordinate of the + // vector is negative, that means that the angle is in quadrants III - IV. double rawAngle = acos(Unit().x); -#if 0 - double correctedAngle = (y < 0 ? (2.0 * PI) - rawAngle : rawAngle); -#else double correctedAngle = (y < 0 ? TAU - rawAngle : rawAngle); -#endif return correctedAngle; } @@ -289,10 +286,10 @@ bool Vector::isZero(double epsilon/*= 1e-6*/) // This is done using the following formula: // (a . b) = ||a|| ||b|| cos(theta) // However, have to check for two degenerate cases, where a = cb: - // 1, if c > 0, theta = 0; 2, if c < 0, theta = 180°. + // 1) if c > 0, theta = 0; 2) if c < 0, theta = 180°. // Also, the vectors a & b have to be non-zero. // Also, have to check using an epsilon because acos will not return an - // exact value if the vectors are orthogonal + // exact value if the vectors are orthogonal. if (a.isZero() || b.isZero()) return 0;