X-Git-Url: http://shamusworld.gotdns.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fjoystick.cpp;fp=src%2Fjoystick.cpp;h=66be33097e6af28452a56a68e62b4b35cacedc34;hb=07e61d8dcf16099a862baee79b4ec1e06d76b3d4;hp=146c15d9e29c547ca5a77efecd58fad27abfb4d9;hpb=966763ef56b837b82cc3727dd95246ba6ae155ce;p=virtualjaguar diff --git a/src/joystick.cpp b/src/joystick.cpp index 146c15d..66be330 100644 --- a/src/joystick.cpp +++ b/src/joystick.cpp @@ -341,7 +341,10 @@ uint8 JoystickReadByte(uint32 offset) // This is bad--we're assuming that a bit is set in the last case. Might not be so! // NOTE: values $7, B, D, & E are only legal ones for pad 0, (rows 3 to 0, in both cases) // $E, D, B, & 7 are only legal ones for pad 1 -// So the following code is WRONG! +// So the following code is WRONG! (now fixed! ;-) +// Also: we should explicitly check for those bit patterns, as other patterns +// are legal and yield other controllers... !!! FIX !!! +#warning "!!! Need to explicitly check for the proper bit combinations! !!!" if (!(pad0Index & 0x01)) pad0Index = 0;